Repository navigation
fix: add missing apiroute monitoring path annotation - #529
Merged
Merged
Conversation
shreddedbacon
marked this pull request as ready for review
September 18, 2026 03:46
Member
Author
|
Might need adjusting if #520 is merged first |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow defaulting change preserves explicit paths, matches the updated ingress expectations, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR fixes missing monitoring-path annotations on API-defined routes by applying the default path while preserving explicitly configured paths.
Changes:
- Default API routes’
MonitoringPathwhen no value is provided. - Update ingress fixtures to expect
monitor.stakater.com/overridePath: /for standard, Fastly, and active/standby routes.
| File | Description |
|---|---|
internal/testdata/node/ingress-templates/api-defined-routes-with-lagoon-yml/test.example.com.yaml |
Expect the default monitoring-path annotation. |
internal/testdata/node/ingress-templates/api-defined-routes-with-lagoon-yml/other.example.com.yaml |
Expect the default path with monitoring disabled. |
internal/testdata/node/ingress-templates/api-defined-routes-with-lagoon-yml-fastly/test.example.com.yaml |
Expect the default path for a Fastly route. |
internal/testdata/node/ingress-templates/api-defined-routes-with-lagoon-yml-fastly/other.example.com.yaml |
Expect the default path for a monitoring-disabled Fastly route. |
internal/testdata/node/ingress-templates/active-standby-api-routes/test.example.com.yaml |
Expect the default path in active/standby configuration. |
internal/testdata/node/ingress-templates/active-standby-api-routes/other.example.com.yaml |
Expect the default path with monitoring disabled. |
internal/testdata/node/ingress-templates/active-standby-api-routes/active.example.com.yaml |
Expect the default path for the migrating active route. |
internal/lagoon/routes.go |
Preserve explicit monitoring paths and default empty values. |
Review effort: Balanced
CGoodwin90
approved these changes
Oct 27, 2026
shreddedbacon
force-pushed
the
fix-missing-apiroute-monitoringpath
branch
from
October 27, 2026 22:45
701a4a3 to
03e9b31
Compare
shreddedbacon
enabled auto-merge (squash)
October 27, 2026 22:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds missing the missing
monitoringPathdefaults on API routes